Repository navigation
feat(lead): link board items to bounded read-only details (#1030) - #1232
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
st merge-flow>author #12328ff6f0a queue=REJECTED run=44207927880 next=refresh-on-main note="Composition with current main failed; rebase/merge main, fix, push; a new head needs a new verdict." |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Feature D (#1214); refs #1030's approved v2 design. Ports #307 row digest + attn-watch (acceptance). T3 for finite item routing at the existing authorized boundary.
Board links open server-rendered /items/{number} with the observed next action, release priority, lease and attempt count from the same borrowed native Board. Item detail keeps Board selected and supports fragment refresh. Canonical positive u64 IDs only; raw heads and payloads are never rendered. Lease formatting is shared with the table. Missing titles/checks/findings/diffs stay explicit until native observations supply them. No producer, store, source read, GitHub call, write handler or activation is added.
Removes: nothing. Current own diff: 94 changed lines in four UI files, after the pagination/filter context shipped through merged #1242. Private mock uncommitted; helpers paused.
Current head 456bda6 normally merges main8e728018 after primary GitHub and merge-tree proved four actual conflicts at14b988f4. It preserves Item plus main Query/filters/pagination/Chat routes and every main CSS line. Complete main live-server controls are byte-identical after removing only the inserted Item block; the entire Item block and shared helpers are unchanged from14b, including the exact200 status diagnostic. Chat runs before main paging/filter fixture writes, then Item controls. Main work_board.rs, work_shadow.rs, report_cmd.rs and oxa-work/lib.rs match byte-for-byte, preserving the current Gate/native reader/runner APIs.
The real binary controls cover Item link/detail, observed fields, Board selection, strict numeric/overflow/path refusals, unknown item, private-head omission and hostile Host denial alongside main Chat,101-row paging and filtered subsets. Before70e45374 failed lane44195055902 on both architectures, sole real-listener missing Item link (failed shard134434283960,1,279/1,280 passing). Controls are retained.
Historical8ff source component/full CI and exact code review passed, but integrated44207927880, immutable tree36616da4, failed the Item response-prefix check at line178 with2,382/2,383 passing. Its lead sources/test were byte-identical to8ff, and the message omitted the returned status.14b strengthened that check to exact HTTP/1.1 200 OK, reporting only the status line on failure; it passed component44210327774 on both architectures and full44210332953. This does not establish the integrated failure's cause or claim a product/auth fix. The stronger diagnostic remains in456b.
Current automatic lane44212444565 and required44212451914 each have one interval120 observer. Current-head CI, independent review and normal queue integration remain required; older greens are historical. No local builds/tests, rebase, empty commit, Ready toggle, manual dispatch, CI restart or enqueue request. No further refresh while current source is mergeable.
Current exact-head terminal qualification: 456bda6 passed lane44212444565 on x86_64 and ARM64, selecting oxa-cli/parity (plan134493924028), and full required44212451914. Strict clippy, real binary, doctests/archive, both mandatory-bwrap partitions, exact inventory and gate succeeded. Both original observers terminated0 and are consumed. Current Codex code review reports no major issues on456bda64b6, with no unresolved threads. Primary is OPEN/Ready/MERGEABLE/CLEAN. Normal independent owner/security and queue integration remain; no enqueue request or further refresh.